Shortening the URL for twitter will save you valuable characters, especially when you want to describe the link.
If you are doing it for affiliate links then a shortened URL looks a lot better than an affiliate link. I can imagine a hand full of people get put off by affiliate links because the strange characters can make the link look kind of dodgy.
I would say a positive effect overall. I have even used Twitter and Twitter shortened the URL for me.